feat(info): expose default network name #27608
Conversation
openshift-ci
bot
added
do-not-merge/release-note-label-needed
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
Hello, could you please remove the vendoring commit from this PR? If this requires a bump of common, I would suggest doing it in a separate PR.
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
Thanks, you need to reorder your commits, the vendor commit should be first otherwise you break the build.
Also please squash the lint commit into the right commit, we don't want fixup commits on PRs as we merge commits as is.
Eh, we do vendoring all the time in the same PR with other changes, as long as you do it in separate commits that is fine. |
I got confused by the failed build. I didn't realize strict ordering was the issue. That's why I thought a separate PR was needed. |
|
#27612 did the vendoring for another feature so you can drop the vendor here and just add the podman test |
kyounghunJang
force-pushed
the
feature/Add-DefaultNetwork
branch
2 times, most recently
from
da91463 to
266ba5a
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Fixes containers#27580 Signed-off-by: Kyounghoon Jang <[email protected]>
kyounghunJang
force-pushed
the
feature/Add-DefaultNetwork
branch
from
266ba5a to
2e26dee
Compare
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
LGTM. It seems Packit is having some issues. I will re-run it.
openshift-ci
bot
added
the
approved
|
/packit retest-failed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, kyounghunJang, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 89844e5
into
containers:main
3 participants
Description
This PR exposes the default network name in
podman infooutput undernetworkBackendInfo.Currently, the default network is usually
podman, but users can customize this incontainers.conf. Downstream tools (like Podman Desktop) and users need a way to programmatically determine what the current default network name is.Fixes #27580
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?